Unity 8

Code review comment for lp://qastaging/~lukas-kde/unity8/stagedCloseShortcut

  1. stagedCloseShortcut
  2. Merge into trunk
Revision history for this message
Michael Terry (mterry) wrote :

OK, this does fix it for me on phones.

- Looks like a test failure in PhoneStage::test_selectAppFromSpread

- Is the comment at the top of onItemRemoved suggesting that we don't do what you just did? If so, maybe we should clarify with someone that there aren't corner cases (I don't know of any off the top of my head where the first in line isn't always focused, but...). And maybe remove the comment too in that case.

- The desktop stage already set focus correctly?

review: Needs Fixing

« Back to merge proposal