Code review comment for lp://qastaging/~mabac/linaro-image-tools/image-support-for-android

On Tue, May 31, 2011, Mattias Backman wrote:
> If it possibly is not needed that might be worth investigating. To me
> calculating stuff for block devices is scary and the less of it there
> is the better I feel. I wouldn't know where to begin though, don't
> have the history of why we do these calculations.

 In the early versions, we were trying to generate sizes which were
 aligned on CHS boundaries; there was also the desire to pass the right
 number of cylinders to sfdisk. Nowadays, I think only QEMU cares about
 the size of the image (I think it prefers if it's a power of 2, but not
 sure how picky it is) and we just try to align the start of partitions
 on power of 2, but that doesn't matter much.

 Perhaps now is the good time to break things so that we have the time
 to understand the new issues and fix them :-)

--
Loïc Minier