Code review comment for lp://qastaging/~mabac/linaro-image-tools/image-support-for-android

Revision history for this message
Mattias Backman (mabac) wrote :

> I think both calculate_android_partition_size_and_offset() and
> get_android_loopback_devices() could do with some basic tests. Something
> as simple as the existing test_calculate_partition_size_and_offset() and
> test_get_boot_and_root_loopback_devices() would be enough, I think.
> Would you be willing to give that a try? I expect it to be quite
> straightforward.

Thanks, Guilherme you're right. Of course I'll add the tests, will
look at it after the extended weekend. :)

>
> --
> Guilherme Salgado <https://launchpad.net/~salgado>
>
> https://code.launchpad.net/~mabac/linaro-image-tools/image-support-for-android/+merge/62950
> You are the owner of lp:~mabac/linaro-image-tools/image-support-for-android.
>

« Back to merge proposal