Code review comment for lp://qastaging/~macslow/unity/unity.fix-841902

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

73 + if (cols == 2)
74 + {
75 + genre_layout_->SetChildrenSize (dash::Style::Instance().GetTileWidth() - 12, 32);
76 + }
77 + else if (cols == 3)
78 + {
79 + genre_layout_->SetChildrenSize (92, 33);
80 + }

Can you add a catch-all else{} branch to this construction, maybe printing a warning? Or if it's unneeded please add a comment that the off-chance is taken care of.

Otherwise looking good.

review: Needs Fixing

« Back to merge proposal