Code review comment for lp://qastaging/~macslow/unity/unity.fix-863246-2

Revision history for this message
Andrea Azzarone (azzar1) wrote :

54 + for (iter = layout_list.begin(); iter != layout_list.end(); iter++)
55 + {
56 + if (i != num_separators)
57 + {
58 + nux::Area* filter_view = (*iter);
59 + nux::Geometry const& geom = filter_view->GetGeometry();
60 +
61 + unsigned int alpha = 0, src = 0, dest = 0;
62 + GfxContext.GetRenderStates().GetBlend(alpha, src, dest);
63 +
64 + GfxContext.GetRenderStates().SetBlend(true, GL_ONE, GL_ONE_MINUS_SRC_ALPHA);
65 + GfxContext.GetRenderStates().SetColorMask(true, true, true, false);
66 + nux::GetPainter().Draw2DLine(GfxContext,
67 + geom.x , geom.y + geom.height - 1,
68 + geom.x + geom.width, geom.y + geom.height - 1,
69 + col);
70 + GfxContext.GetRenderStates().SetBlend(alpha, src, dest);
71 + }
72 + i++;
73 + }

Why not to use the for (auto iter : layout_list) statement?

Please use ++bla intead of bla++ too :)

91 + SetMinimumHeight(30);
92 + SetMinimumWidth(48);

Can we use const variables instead of magic numbers for the moment?

+static const float kExpandDefaultIconOpacity = 1.0f;

Don't make it static, put it in an anonymouse namespace.

review: Needs Fixing

« Back to merge proposal