Ubuntu One Control Panel

Merge lp://qastaging/~mandel/ubuntuone-control-panel/add-app-name into lp://qastaging/ubuntuone-control-panel

  1. add-app-name
  2. Merge into trunk
Proposed by Manuel de la Peña
Status: Merged
Approved by: Natalia Bidart
Approved revision: 283
Merged at revision: 285
Proposed branch: lp://qastaging/~mandel/ubuntuone-control-panel/add-app-name
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 43 lines (+7/-2)
2 files modified
ubuntuone/controlpanel/tests/test_web_client.py (+5/-0)
ubuntuone/controlpanel/web_client.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~mandel/ubuntuone-control-panel/add-app-name
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Diego Sarmentero (community) Approve
Review via email: mp+97071@code.qastaging.launchpad.net

Commit message

- Added the app name from ubuntu one to be used in the webclient so that it is shown in the sso ui (LP: #952880).

Description of the change

- Added the app name from ubuntu one to be used in the webclient so that it is shown in the sso ui (LP: #952880).

To post a comment you must log in.
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

needs tests

review: Needs Fixing
lp://qastaging/~mandel/ubuntuone-control-panel/add-app-name updated
283. By Manuel de la Peña

Added test to ensure that the correct app name is used.

Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Looks good, though the platform import is out of order :-).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: