Code review comment for lp://qastaging/~manishsinha/gedit/enable-zeitgeist-datasource-plugin
Revision history for this message
| Didier Roche-Tolomelli (didrocks) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
Some additional comment on the merge req (same for the totem one that has been merged as well):
+ libzeitgeist-1.0-1
-> this isn't needed and in addition, should be avoided at soon as possible. You are forcing a dependency on a versionned libzeitgeist soname, which means that if we have a new libzeitgeist, we need to change the gedit packaging (and all other packages depending on libzeitgeist, which will be a lot). Basically we just rebuild them.
libzeitgeist-1.0-1 (>= 0.3.2) is automatically added by dh_shlibdeps which expands ${shlibs:Depends}, and replace with library dependencies.
I fixed it directly in gedit upload and going to fix totem as well. If you want more info on that, please use man dh_shlibdeps ;)
I activated the plugin by default as well.
Thanks for your work there!