Online Accounts: GNOME Control Center

Merge lp://qastaging/~mardy/gnome-control-center-signon/provider-data into lp://qastaging/gnome-control-center-signon

provider-data
Merge into trunk

Proposed by Alberto Mardegan on 2013-01-31

Status:	Merged
Approved by:	Alberto Mardegan on 2013-02-06
Approved revision:	136
Merged at revision:	133
Proposed branch:	lp://qastaging/~mardy/gnome-control-center-signon/provider-data
Merge into:	lp://qastaging/gnome-control-center-signon
Diff against target:	156 lines (+40/-12) 6 files modified configure.ac (+3/-1) debian/control (+1/-1) libaccount-plugin/account-plugin.pc.in (+1/-0) libaccount-plugin/oauth-plugin.c (+21/-9) tests/data/MyProvider.provider (+11/-0) tests/test-account-plugin.vala (+3/-1)
To merge this branch:	bzr merge lp://qastaging/~mardy/gnome-control-center-signon/provider-data
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
David King (community)		2013-01-31	Approve on 2013-02-06
PS Jenkins bot (community)	continuous-integration		Needs Fixing on 2013-01-31
Review via email: mp+145786@code.qastaging.launchpad.net

Description of the change

Read authentication settings from .provider file

When configuring the account, also read all the authentication parameters defined in the .provider file, and merge them with those explicitly defined by the plugin binary.

Also, add a dependency on GModule, from which we are using g_module_make_resident().

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2013-01-31:

FAILED: Continuous integration, rev:135
http://s-jenkins:8080/job/gnome-control-center-signon-ci/21/
Executed test runs:
FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=amd64/21/console
FAILURE: http://s-jenkins:8080/job/gnome-control-center-signon-ci/./build=pbuilder,distribution=raring,flavor=i386/21/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gnome-control-center-signon-ci/21//rebuild/?

review: Needs Fixing (continuous-integration)

Revision history for this message

David King (amigadave) wrote on 2013-01-31:

12 @@ -105,6 +106,7 @@
13 [$LIBACCOUNTS_GLIB_REQUIRED
14 $LIBSIGNON_GLIB_REQUIRED
15 $GLIB_REQUIRED
16 + $GMODULE_REQUIRED
17 $GTK_REQUIRED])

If you depend on a module but do not expose the symbols publically, also add the dependency to Requires.private, for example:

http://bazaar.launchpad.net/~amigadave/gnome-control-center-signon/switch-mockup/revision/134

75 + account_service = ag_account_service_new (account, NULL);
76 + auth_data = ag_account_service_get_auth_data (account_service);
77 + if (auth_data != NULL)

rather than handling a NULL auth_data here, I would rather bump the libaccounts-glib dependency in configure.ac. This also suggests that it might be a good idea to switch to a post-release version bump strategy for libaccounts-glib, so that one can depend on the (unreleased) 1.8 rather than being inaccurate and depending on 1.7. More detail at:

https://live.gnome.org/MaintainersCorner/Releasing

review: Needs Fixing

lp://qastaging/~mardy/gnome-control-center-signon/provider-data updated on 2013-01-31