Code review comment for lp://qastaging/~mardy/gnome-control-center-signon/provider-data

12 @@ -105,6 +106,7 @@
13 [$LIBACCOUNTS_GLIB_REQUIRED
14 $LIBSIGNON_GLIB_REQUIRED
15 $GLIB_REQUIRED
16 + $GMODULE_REQUIRED
17 $GTK_REQUIRED])

If you depend on a module but do not expose the symbols publically, also add the dependency to Requires.private, for example:

http://bazaar.launchpad.net/~amigadave/gnome-control-center-signon/switch-mockup/revision/134

75 + account_service = ag_account_service_new (account, NULL);
76 + auth_data = ag_account_service_get_auth_data (account_service);
77 + if (auth_data != NULL)

rather than handling a NULL auth_data here, I would rather bump the libaccounts-glib dependency in configure.ac. This also suggests that it might be a good idea to switch to a post-release version bump strategy for libaccounts-glib, so that one can depend on the (unreleased) 1.8 rather than being inaccurate and depending on 1.7. More detail at:

https://live.gnome.org/MaintainersCorner/Releasing