lp://qastaging/~mardy/signon/test-ui-cancel

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1573098: Keep authentication dialogs open until authentication completes

Medium

Confirmed

Link a bug report

Related blueprints

685. By Alberto Mardegan on 2016-05-26

don't build qt4 stuff

* For testing PPA.
* debian/control, debian/libsignon-qt{1,-dev}.install, debian/rules:
  Don't build Qt4 packages.

684. By Alberto Mardegan on 2016-05-26

test branch

683. By Alberto Mardegan on 2016-05-26

lib: add more defines for SignOnUi password dialog

682. By Alberto Mardegan on 2016-05-26

signond: inform SignOnUI when a session finishes

This allows SignOnUi to retain its window open (if it wishes to) in
order to fluidly update it when the next request comes. This is
especially useful in the case of password-based authentications, when
the UI might want to update itself with error messages, captchas or
other fields.

We implement this by reusing the cancelUiRequest() method. In order to
avoid spawning SignOnUi without reason, we call the method only if a
SignOnUi window has been active for this request. Signond already had a
property for tracking this (m_queryCredsUiDisplayed) but it appears it
was not updated accurately; this commit fixes that.

A unit test to verify that cancelUiRequest() is being called when
expected is also added.

681. By Alberto Mardegan on 2016-05-18

RemotePluginProcess: don't use a thread for cancel

The CancelThread implementation is complex and smells of poor knowledge
and cargo programming.
Here we remove that class, and instead handle cancelling events in the
same thread: this makes code much simpler and is enough for our plugins,
which always spend more time waiting for network replies than in actual
computations.

In order to achieve this, a small change is needed to the BlobIoHandler
class, to let its client know when it's in the middle of a read
operation (we don't want to read from the socket at that time, or we'd
be stealing data from it).

The ssotest plugin also needed to be adjusted to avoid using mutexes and
replace busy waits with a QTimer.

680. By Alberto Mardegan on 2016-05-17

Enable CI in gitlab

679. By Alberto Mardegan on 2016-05-16

Signond: fix a couple of textual issues

There was a spelling mistake in the error message returned to clients,
and a misleading comment in the code.

678. By Alberto Mardegan on 2016-05-16

Build: use qmake's DBUS_ADAPTORS to build the backup adaptor

This ensures that the resulting files are generated inside the build
directory.

677. By Alberto Mardegan on 2016-05-16

signond: get rid of loadedPluginMethods() method

This internel method was a premature optimization introduced before the
project went public. It doesn't seem needed, especially given that it's
used to implement the nearly useless AuthService::queryMechanisms()
(usually, one would query the mechanisms on the AuthSession object, if
ever).

676. By Alberto Mardegan on 2016-05-16

plugins: don't use custom proxy implementation on Qt 5.5 and later

Qt 5.5 finally got a libproxy implementation of QNetworkProxyFactory
(see QTBUG-26295), so we don't need our custom code anymore.