Code review comment for lp://qastaging/~mardy/unity-scope-gdrive/python3

Revision history for this message
Ken VanDine (ken-vandine) wrote :

First issue:
-#! /usr/bin/python
+#! /usr/bin/python3

I am also getting tracebacks:

** (process:31026): CRITICAL **: Unsupported type PyObject

(process:31026): GLib-GIO-CRITICAL **: g_dbus_gvalue_to_gvariant: assertion `type != NULL' failed
/usr/lib/python3/dist-packages/gi/types.py:47: Warning: g_variant_new_variant: assertion `value != NULL' failed
  return info.invoke(*args, **kwargs)
/usr/lib/python3/dist-packages/gi/types.py:47: Warning: g_variant_get_type: assertion `value != NULL' failed
  return info.invoke(*args, **kwargs)
/usr/lib/python3/dist-packages/gi/types.py:47: Warning: g_variant_type_is_subtype_of: assertion `g_variant_type_check (type)' failed
  return info.invoke(*args, **kwargs)
/usr/lib/python3/dist-packages/gi/types.py:47: Warning: g_variant_builder_add_value: assertion `!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed
  return info.invoke(*args, **kwargs)
/usr/lib/python3/dist-packages/gi/types.py:47: Warning: g_variant_builder_end: assertion `GVSB(builder)->offset >= GVSB(builder)->min_items' failed
  return info.invoke(*args, **kwargs)
login finished
Traceback (most recent call last):
  File "/usr/lib/unity-lens-files/unity-scope-gdocs", line 103, in login_cb
    if reply.has_key("AuthToken"):
AttributeError: 'dict' object has no attribute 'has_key'
Got the same token
p11-kit: duplicate configured module: gnome-keyring.module: /usr/lib/x86_64-linux-gnu/pkcs11/gnome-keyring-pkcs11.so

** (process:31026): CRITICAL **: Unsupported type PyObject

(process:31026): GLib-GIO-CRITICAL **: g_dbus_gvalue_to_gvariant: assertion `type != NULL' failed
login finished
Traceback (most recent call last):
  File "/usr/lib/unity-lens-files/unity-scope-gdocs", line 103, in login_cb
    if reply.has_key("AuthToken"):
AttributeError: 'dict' object has no attribute 'has_key'
Got the same token

review: Needs Fixing

« Back to merge proposal