Code review comment for lp://qastaging/~mardy/unity-scope-gdrive/python3

Revision history for this message
Ken VanDine (ken-vandine) wrote :

> > First issue:
> > -#! /usr/bin/python
> > +#! /usr/bin/python3
>
> I was hoping that, with python2 removed, "/usr/bin/python" would just point to
> python3.
> I'm a bit unsure whether it's a good idea to force python3 here, since the
> lens can also work with python2.

I am pretty sure the plan is to keep python and python3 separate, python3 is too different to really make that kind of transition go smoothly.

>
> > I am also getting tracebacks:
> >
> > ** (process:31026): CRITICAL **: Unsupported type PyObject
> [...]
>
> Yes, I also got them :-)
> The problem is with the libsignon-glib pygobject "overrides", which gets
> installed only in the directory given by
>
> `$PYTHON -c "import gi;print gi._overridesdir"`
>
> and since $PYTHON runs python-2.7, this is not available for python3. Ideally,
> we'd like these pygobject overrides to be available to all versions of python
> installed on the system; any idea how to achieve that?

I can fix that.

« Back to merge proposal