Code review comment for lp://qastaging/~mariosplivalo/charms/trusty/percona-cluster/lp1366997-workaround

Revision history for this message
Billy Olsen (billy-olsen) wrote :

From my understanding this config flag option 'lp1366997-workaround' is a flag which will be short-lived and hopefully removed if the upstream fix gets backported. I think it'd be best if we can find a solution which avoids the need for future deprecation.

If we can, I think it my be a good idea to have a flexible option which allows other options to be defined in a configuration file in the conf.d directory. This allows us to address this use case and possible future use cases without having to do additional code change with the convenient side-effect of avoiding the option deprecation/removal.

At the very least I think the config option should be renamed to convey a better indicator of what is addressing (symptom even) rather than the lpbug-workaround.

One other possible option is to simply enable this workaround all the time within the template. I'm not entirely sure of what the side-effects are of enabling these options so that may be the least desirable due to inadvertent risk (which is why it is toggled in the first place).

review: Needs Fixing

« Back to merge proposal