Merge lp://qastaging/~matthew-hart/lava-lab/fix-fmnetwork into lp://qastaging/lava-lab

Proposed by Matthew Hart
Status: Merged
Approved by: Matthew Hart
Approved revision: 306
Merged at revision: 305
Proposed branch: lp://qastaging/~matthew-hart/lava-lab/fix-fmnetwork
Merge into: lp://qastaging/lava-lab
Diff against target: 79 lines (+5/-41)
1 file modified
lava/fastmodels/FMNetwork (+5/-41)
To merge this branch: bzr merge lp://qastaging/~matthew-hart/lava-lab/fix-fmnetwork
Reviewer Review Type Date Requested Status
Antonio Terceiro Approve
Review via email: mp+184150@code.qastaging.launchpad.net

Description of the change

Use br0 device on fastmodels servers instead of creating one from eth0

To post a comment you must log in.
Revision history for this message
Antonio Terceiro (terceiro) wrote :

Mostly-red diffs FTW \o/

 review approve

Just a small nitpick:

> === modified file 'lava/fastmodels/FMNetwork'
> --- lava/fastmodels/FMNetwork 2013-06-25 10:45:05 +0000
> +++ lava/fastmodels/FMNetwork 2013-09-05 17:09:24 +0000
> @@ -32,7 +32,8 @@
> INTERFACES="01 02"
> NIC=eth0
> PREFIX=armv8_
> -BRIDGE=armbr0
> +#BRIDGE=armbr0
> +BRIDGE=br0

remove that commented line, we use version control for a reason :)

review: Approve
306. By Matt Hart <matt@6430u.local>

Removed un-need comment :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches