LAVA Validation Lab

Code review comment for lp://qastaging/~matthew-hart/lava-lab/fix-fmnetwork

  1. fix-fmnetwork
  2. Merge into salt-states
Revision history for this message
Antonio Terceiro (terceiro) wrote :

Mostly-red diffs FTW \o/

 review approve

Just a small nitpick:

> === modified file 'lava/fastmodels/FMNetwork'
> --- lava/fastmodels/FMNetwork 2013-06-25 10:45:05 +0000
> +++ lava/fastmodels/FMNetwork 2013-09-05 17:09:24 +0000
> @@ -32,7 +32,8 @@
> INTERFACES="01 02"
> NIC=eth0
> PREFIX=armv8_
> -BRIDGE=armbr0
> +#BRIDGE=armbr0
> +BRIDGE=br0

remove that commented line, we use version control for a reason :)

review: Approve

« Back to merge proposal