Code review comment for lp://qastaging/~maxb/bzrtools/fix-version-check

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Max Bowsher wrote:
> Max Bowsher has proposed merging lp:~maxb/bzrtools/fix-version-check into lp:bzrtools.
>
> Requested reviews:
> Aaron Bentley (abentley)
>
>
> I tried using bzrtools trunk with bzr 2.0, and got a nasty exception. The incompatibility error is assuming that bzrtools' own version_info is always a 3-tuple, but it's a 5-tuple at the moment.

 merge approved

Thanks, taken.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkr48EgACgkQ0F+nu1YWqI0+bgCfTKsM8Li0CG9rBF+RaD3g+OEW
wNcAnR/aiyztByoPmDnleZtI2XdHnhXo
=uMYh
-----END PGP SIGNATURE-----

review: Approve

« Back to merge proposal