Merge lp://qastaging/~mbruzek/charms/precise/rabbitmq-server/add-tests into lp://qastaging/charms/rabbitmq-server
Proposed by
Matt Bruzek
Status: | Merged |
---|---|
Merged at revision: | 74 |
Proposed branch: | lp://qastaging/~mbruzek/charms/precise/rabbitmq-server/add-tests |
Merge into: | lp://qastaging/charms/rabbitmq-server |
Diff against target: |
657 lines (+605/-1) 9 files modified
Makefile (+5/-1) tests/00_setup.sh (+16/-0) tests/10_basic_deploy_test.py (+101/-0) tests/20_deploy_relations_test.py (+214/-0) tests/30_configuration_test.py (+142/-0) tests/amqp_tester.py (+65/-0) tests/rabbit-server-cacert.pem (+17/-0) tests/rabbit-server-cert.pem (+18/-0) tests/rabbit-server-privkey.pem (+27/-0) |
To merge this branch: | bzr merge lp://qastaging/~mbruzek/charms/precise/rabbitmq-server/add-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Review Queue (community) | automated testing | Needs Fixing | |
José Antonio Rey (community) | charmers | Approve | |
Ryan Beisner (community) | Approve | ||
Review via email: mp+246025@code.qastaging.launchpad.net |
Description of the change
Adding tests for the rabbitmq-server charm.
To post a comment you must log in.
Thank you for the amulet test coverage work on rmq, much appreciated!
If we can get this added to Makefile, that will make OSCI's engine happy:
test:
@echo Starting amulet tests...
@juju test -v -p AMULET_HTTP_PROXY --timeout 900
I just sent your branch with ^ that mod through to confirm: test.conductor. 00_setup. sh RESULT : ✔ test.conductor. 10_basic_ deploy_ test.py RESULT : ✔ test.conductor. 20_deploy_ relations_ test.py RESULT : ✔ test.conductor. 30_configuratio n_test. py RESULT : ✔
juju-
juju-
juju-
juju-
juju-test INFO : Results: 4 passed, 0 failed, 0 errored
I think most of the openstack charms use the 'test' target name. But actually, you can name the make target anything as OSCI just looks for '@juju test' in a target and runs that target.