Code review comment for lp://qastaging/~mc-return/compiz/compiz.merge-fix1165198-horizontally-semimaximized-windows-do-not-snap-off-easily

Revision history for this message
MC Return (mc-return) wrote :

> Okay, further investigation shows that the SNAP_BACK code has some purpose -
> it is the one I speculated about above...
>
> TODO: Although snapping back horizontally maxed windows does not make that
> much sense,
> it should be implemented as well to harmonize snap off/snap back
> behaviour of
> those window types...
>
Done (in local branch).

> TODO: SNAP_BACK and SNAP_OFF are constants, but should ideally be configurable
> also
> (distance in pixels, the mouse has to travel to snap off/snap back).

Done (in local branch).

@Sam: There will be a new MP hopefully soonish. Got almost all move problems
      figured out now (finally)...
      The back-snapping of horizontally maxed wins still makes (very minor)
      problems - should work for left & right sides IMHO...
      In my local branch I made backsnapping configurable as well :)
      This is how it currently looks:
      http://uppix.net/1/1/e/06bbae1c05a85dc86ea0870b52ead.png

« Back to merge proposal