Merge lp://qastaging/~mcintire-evan/music-app/songs-fastscroll into lp://qastaging/music-app

The code for this looks good! I'm not sure however, that we'll want to merge this into the app. The Ubuntu SDK will be introducing scrollbars sometime soon and I think it'd be better to use that feature/component as we'll also want to use it in the Queue and other listviews.

Codewise, I do have 1 inline comment.

Thanks for the review, you are right with the ListItems comment.

As for actual merging it, ahayzen did tell me that it probably wouldn't be merged, but getting a working example with it was still a good idea, so I understand

Awesome, thanks for doing this.

I have on minor inline comment that assists with the styling after moving to the new ListItem component. I also agree with Victor that we'll likely wait for the new SDK scrollbars to see which is best, or a mixture of both. As when testing this you can get it into states where the header covers the letters on the right side, and on smaller screens (eg when in landscape) the fastscroll component does not fit in the vertical space.

1) This label should probably have
anchors {
    leftMargin: units.gu(1)
    verticalCenter: parent.verticalCenter
}
so that it is vertically centred and not against the left edge

Sorry for the late reply, school got in the way

I've tried applying those anchors to the label, but the leftMargin doesnt seem to do anything, here are some screenshots

http://i.imgur.com/DIEMOdf.png is with the anchors

http://i.imgur.com/fazBT7K.png is without

It seems the verticalCenter works, but leftMargin does not, even if I up the units.gu unit

Try using

anchors {
  left: parent.left
  leftMargin: units.gu(1)
  right: parent.right
  rightMargin: units.gu(1)
  verticalCenter: parent.verticalCenter
}

Its probably because it doesn't have anything to bind to on the left side, so then just uses the x value.
By then setting left: parent.left that should then let you use leftMargin.

Formatting is fixed, but I noticed a bug

If you longpress, you are able to select the category headers the same way you would select a song

http://i.imgur.com/sRFgZin.png is a screenshot of that

FAILED: Continuous integration, rev:960
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~mcintire-evan/music-app/songs-fastscroll/+merge/281471/+edit-commit-message

https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/216/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-update-mp/502/console

Click here to trigger a rebuild:
https://core-apps-jenkins.ubuntu.com/job/run-ap-tests-ci/216/rebuild