Code review comment for lp://qastaging/~mcintire-evan/music-app/songs-fastscroll

Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Awesome, thanks for doing this.

I have on minor inline comment that assists with the styling after moving to the new ListItem component. I also agree with Victor that we'll likely wait for the new SDK scrollbars to see which is best, or a mixture of both. As when testing this you can get it into states where the header covers the letters on the right side, and on smaller screens (eg when in landscape) the fastscroll component does not fit in the vertical space.

1) This label should probably have
anchors {
    leftMargin: units.gu(1)
    verticalCenter: parent.verticalCenter
}
so that it is vertically centred and not against the left edge

review: Needs Fixing

« Back to merge proposal