Merge lp://qastaging/~mcintire-evan/ubuntu-terminal-app/splash-screen into lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Evan McIntire
Status: Merged
Approved by: Alan Pope 🍺🐧🐱 πŸ¦„
Approved revision: 175
Merged at revision: 175
Proposed branch: lp://qastaging/~mcintire-evan/ubuntu-terminal-app/splash-screen
Merge into: lp://qastaging/~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 8 lines (+1/-0)
1 file modified
com.ubuntu.terminal.desktop.in.in (+1/-0)
To merge this branch: bzr merge lp://qastaging/~mcintire-evan/ubuntu-terminal-app/splash-screen
Reviewer Review Type Date Requested Status
Alan Pope 🍺🐧🐱 πŸ¦„ (community) Approve
Stefano Verzegnassi Approve
Jenkins Bot continuous-integration Approve
Niklas Wenzel (community) Needs Fixing
Bartosz Kosiorek (community) Approve
Review via email: mp+285673@code.qastaging.launchpad.net

Commit message

Uses the new splash screen features as per bug #1377638

Description of the change

Uses the new splash screen features as per bug #1377638

To post a comment you must log in.
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

Works perfectly for me

review: Approve
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Sorry Evan for being that hateful guy, but the branch surely needs a fix. :)

Line 9 of the diff should be:
_X-Ubuntu-Splash-Title=Terminal

Note the underscore before "X-Ubuntu-Splash-Title". That way "Terminal" can be properly translated into user's language.

As for the rest, I'm not sure if we really want to show an header since we don't have any header in the main page of terminal-app.
This is anyway not a important question, so feel free to choose the design you prefer :)

review: Needs Fixing
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :

I agree we should not have a header where the app has none.

Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thank you, Evan, for going through the old bugs and trying to fix them!

Here are two screenshots comparing the old and the newer version:
https://drive.google.com/file/d/0B19TeQHX9rTYOVVIT0pPRmU2MW8/view?usp=sharing
https://drive.google.com/file/d/0B19TeQHX9rTYNVRzMW11Qzd6clE/view?usp=sharing

What I like about the old one is that it features the app icon and the application name neatly centered with the spinner below. I have to say that I really like the awesome terminal app icon on that dark background.

What I like about the newer version is the new background color. I think it looks more friendly than the old one. However, I have to agree with Stefano and Alan that an application header where the app uses none looks a bit out of place.

What do you think about disabling the header again but keeping the color? :)

That's what I think would look best, and additionally you wouldn't have to worry about the translations thing. ;)

review: Needs Fixing
Revision history for this message
Evan McIntire (mcintire-evan) wrote :

Alright - sounds good to me :) I do like the version without the header better too, give me just a moment

175. By Evan McIntire

Remove header

Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Great, LGTM. Thank you!

review: Approve
Revision history for this message
Alan Pope 🍺🐧🐱 πŸ¦„ (popey) wrote :
review: Approve
Revision history for this message
Niklas Wenzel (nikwen) wrote :

Thanks, Evan!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches