Code review comment for lp://qastaging/~mcintire-evan/ubuntu-terminal-app/splash-screen

Revision history for this message
Stefano Verzegnassi (verzegnassi-stefano) wrote :

Sorry Evan for being that hateful guy, but the branch surely needs a fix. :)

Line 9 of the diff should be:
_X-Ubuntu-Splash-Title=Terminal

Note the underscore before "X-Ubuntu-Splash-Title". That way "Terminal" can be properly translated into user's language.

As for the rest, I'm not sure if we really want to show an header since we don't have any header in the main page of terminal-app.
This is anyway not a important question, so feel free to choose the design you prefer :)

review: Needs Fixing

« Back to merge proposal