Code review comment for lp://qastaging/~mehrdada/compiz/compiz.plugins-put

Revision history for this message
Mehrdad Afshari (mehrdada) wrote :

I don't think abs(...)%nOutputDev is the proper way to handle it. We want "-1" to represent the last display, i.e. display #4 on a 5-monitor system. By abs-ing it, we'll get 1 % 5 = 1, which will move the window to the second display (#1) instead.
(We may want to assert that the expression inside abs is non-negative, but silently taking the absolute value sounds like sweeping something under the rug.)

(Sorry for the mistake again. It happened because I originally made the change on`apt-get source compiz-plugins-main` and then pulled the Bazaar repo and had to merge the changes into it again.)

« Back to merge proposal