dee

Code review comment for lp://qastaging/~mhr3/dee/easy-hints

Revision history for this message
Michal Hruby (mhr3) wrote :

> 285 + g_variant_builder_add (builders[col_idx], "{sv}",
> 286 + col_name, // FIXME: "::"
> 287 + collect_variant (col_schema,
> args));
>
> I think "::" needs to be handled?

Indeed, I'm getting very good at forgetting my own FIXMEs :)

> Question: what happens if there are two a{sv} fields in the model, and both
> have some common fields (e.g. "id")?
> Would something like:
> dee_model_build_named_row (fix->model, "object-path", "/org/example",
> "field1::id", 8123, "field2::id", 1111, NULL) just work?

That was the idea.

« Back to merge proposal