Code review comment for lp://qastaging/~mhr3/unity-lens-files/fix-841847

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Tested against Unity trunk and works very well.

460 +/*
461 private string get_current_type ()
462 {
463 - /* Get the current type to filter by */
464 + // Get the current type to filter by
465 var filter = scope.get_filter ("type") as RadioOptionFilter;
466 Unity.FilterOption? option = filter.get_active_option ();
467 return option == null ? "all" : option.id;
468 }
469 -
470 +*/

Any specific reason to keep this in?

Apart from the that the code looks great.

On the behavior: One change from the current ways is that the Folders category now lists recent folders after the Gtk bookmarks. Is that intentional? (fwiw, I found use of it already while testing this branch - so if it wasn't on purpose we might want to check with John if we can keep it... :-))

review: Needs Information

« Back to merge proposal