Unity

Code review comment for lp://qastaging/~mhr3/unity/fix-856205

  1. fix-856205
  2. Merge into 4.0
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I tested this quite thoroughly and it seems to work well. Code looks good too. Although there are some nitpicks:

 i) in ResetSearchState() Why reinterpret_cast and not static_cast?

 ii) in ResetSearchState() should we not g_source_remove (searching_timeout_id_); if the id != 0?

review: Approve

« Back to merge proposal