Merge lp://qastaging/~mhr3/unity/fix-929506 into lp://qastaging/unity

Proposed by Michal Hruby
Status: Superseded
Proposed branch: lp://qastaging/~mhr3/unity/fix-929506
Merge into: lp://qastaging/unity
Diff against target: 678 lines (+281/-179)
5 files modified
UnityCore/FilesystemLenses.cpp (+225/-166)
UnityCore/FilesystemLenses.h (+42/-4)
plugins/unityshell/src/BFBLauncherIcon.cpp (+5/-4)
plugins/unityshell/src/BFBLauncherIcon.h (+1/-1)
tests/test_filesystem_lenses.cpp (+8/-4)
To merge this branch: bzr merge lp://qastaging/~mhr3/unity/fix-929506
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Needs Fixing
Review via email: mp+92846@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2012-02-21.

Description of the change

Makes the lazy loading of the lenses even more lazy, although there's currently an issue that the first right click on the BFB button will result in empty quicklist. (but the lenses aren't started immediately)

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I think you need to fix the right click on the bfb in order for this to be acceptable. It is not entirely unlikely that this could be a user's first interaction...

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.