Unity

Merge lp://qastaging/~mhr3/unity/fix-929506 into lp://qastaging/unity

fix-929506
Merge into trunk

Proposed by Michal Hruby on 2012-02-21

Status:

Superseded

Proposed branch:

lp://qastaging/~mhr3/unity/fix-929506

Merge into:

lp://qastaging/unity

Diff against target:

706 lines (+284/-182)

6 files modified

UnityCore/FilesystemLenses.cpp (+225/-166)
UnityCore/FilesystemLenses.h (+42/-4)
plugins/unityshell/src/BFBLauncherIcon.cpp (+5/-4)
plugins/unityshell/src/BFBLauncherIcon.h (+1/-1)
tests/data/lenses/files/files.lens (+1/-1)
tests/test_filesystem_lenses.cpp (+10/-6)

To merge this branch:

bzr merge lp://qastaging/~mhr3/unity/fix-929506

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Gord Allott (community)		Approve on 2012-02-21
Mikkel Kamstrup Erlandsen	2012-02-21	Pending
Review via email: mp+94015@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2012-02-13.

This proposal has been superseded by a proposal from 2012-02-22.

Description of the change

Splits out the .lens file reading out of FilesystemLenses class and exposes it in LensDirectoryReader, this allows the BFB to directly check the lens files from the disk and we don't start up the lenses as soon as unity starts.

Revision history for this message

Mikkel Kamstrup Erlandsen (kamstrup) wrote on 2012-02-20: Posted in a previous version of this proposal

I think you need to fix the right click on the bfb in order for this to be acceptable. It is not entirely unlikely that this could be a user's first interaction...

review: Needs Fixing

Revision history for this message

Michal Hruby (mhr3) wrote on 2012-02-21:

Of course, the first attempt was to do it without an API/ABI break, this time it's with ABI break.

Revision history for this message

Gord Allott (gordallott) wrote on 2012-02-21:

Works well and the test suite we have covering the filesystemlens object passes perfectly, approving

review: Approve