Thumbnailer

Merge lp://qastaging/~michihenning/thumbnailer/disable-tests into lp://qastaging/thumbnailer

  1. disable-tests
  2. Merge into trunk
Proposed by Michi Henning
Status: Merged
Approved by: Michi Henning
Approved revision: 155
Merged at revision: 150
Proposed branch: lp://qastaging/~michihenning/thumbnailer/disable-tests
Merge into: lp://qastaging/thumbnailer
Prerequisite: lp://qastaging/~michihenning/thumbnailer/merge-crossbuild
Diff against target: 218 lines (+87/-36)
9 files modified
CMakeLists.txt (+22/-0)
debian/changelog (+22/-35)
doc/libthumbnailer-qt/examples/qt_example_test.cpp (+7/-0)
tests/dbus/dbus_test.cpp (+7/-0)
tests/image-provider/image-provider_test.cpp (+7/-0)
tests/libthumbnailer-qt/libthumbnailer-qt_test.cpp (+7/-0)
tests/qml/qml_test.cpp (+7/-0)
tests/slow-vs-thumb/slow-vs-thumb_test.cpp (+1/-1)
tests/stress/stress_test.cpp (+7/-0)
To merge this branch: bzr merge lp://qastaging/~michihenning/thumbnailer/disable-tests
Reviewer Review Type Date Requested Status
Michi Henning (community) Approve
James Henstridge Approve
Timo Jyrinki Needs Information
Review via email: mp+306566@code.qastaging.launchpad.net

Commit message

Disabled QDBus-related tests on xenial and yakkety for the time being due to problems with Qt 5.6. See
    https://bugs.launchpad.net/ubuntu/+source/thumbnailer/+bug/1613561
    https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1625930

Description of the change

Disabled QDBus-related tests on xenial and yakkety for the time being due to problems with Qt 5.6. See
    https://bugs.launchpad.net/ubuntu/+source/thumbnailer/+bug/1613561
    https://bugs.launchpad.net/ubuntu/+source/qtbase-opensource-src/+bug/1625930

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks good otherwise, but why on xenial, as they pass there?

review: Needs Information
Revision history for this message
Michi Henning (michihenning) wrote :

Timo: They don't pass on xenial. Had a failure yesterday on xenial too.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Ok, but just flakiness? Trainguards and core-devs can retry them easily. I mean, they are possible to get to pass on xenial+overlay like https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/1969/+packages (succeeded on first try) but always failing on yakkety so there's a difference.

But as you wish, just commented when noticed.

Revision history for this message
Michi Henning (michihenning) wrote :

This bug has "race condition" written all over it. We've seen this fail on yakkity, and once on xenial on powerpc (where it has never failed in yakkity so far).

I'm not really interested in trying to keep these tests running just in case that they make it through by accident, only to fail again at some other inconvenient point in time.

We'll make it a priority to try and re-enable the tests ASAP. But, for now, and to unblock unity8, I want to be sure that there are no more glitches or surprises.

Revision history for this message
James Henstridge (jamesh) wrote :

Yep. The common factor is Qt 5.6, which is shared by xenial+overlay and yakkety.

review: Approve
Revision history for this message
Michi Henning (michihenning) wrote :

Re-approving because James is on leave.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: