Code review comment for lp://qastaging/~midokura/nova/network-refactoring-l2

> 44 + if not FLAGS.stub_network:
>
> Is this truly necessary? Test/stubbing code should only be in tests, not in
> module code. Is this something we might look at quickly while doing this re-
> factoring?

I had a similar thought but then I remember that pattern was in use in a number of places in the internal Nova code. I think a separate refactoring patch that removed FLAGS.stub_blah flags would be a better approach.

> 1158 +# Copyright (C) 2011 Midokura KK
> 1159 +# Copyright (C) 2011 Nicira, Inc
>
> I'm not certain, but I believe code belongs to OpenStack, LLC?

Leaving company/individual contributor copyright headers in the code for large portions of original code is OK, I believe. The CLA does not require copyright assignment; it grants the OpenStack LLC copyright rights to distribute/redistribute the code... The CLA ensures that the contributed code is not patent-encumbered and that the contributor is legally able to contribute the code.

Cheers!
jay