Code review comment for lp://qastaging/~midokura/nova/network-refactoring-l2

Revision history for this message
Ryu Ishimoto (ryu-midokura) wrote :

Brian, thanks for your thorough review.

> 44 + if not FLAGS.stub_network:
>
> Is this truly necessary? Test/stubbing code should only be in tests, not in
> module code. Is this something we might look at quickly while doing this re-
> factoring?

I completely agree that all the stubbing logic should be moved out of the compute manager. Unfortunately, as Jay pointed out, it's used in many places in Nova and some unit tests rely on this flag to be set for them to run successfully, which is why I added this flag here. Since fixing this will require non-trivial changes in Nova somewhat unrelated to this branch, Jay's suggestion to have another re-factoring branch focused on fixing this particular issue sounds like a good idea to me. What do you think?

I made all the other changes you suggested.

Thanks,
Ryu

« Back to merge proposal