Code review comment for lp://qastaging/~mikemc/ubuntuone-control-panel/add-to-favorites-mac
Revision history for this message
| Mike McCracken (mikemc) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
demo site
(Get the code!)
As per discussion on irc, rev 393 uses NSUserDefaults instead of the ad hoc flag file.
This is good for two reasons:
1. the code is a little nicer (although due to a required wrapper for testing calls to NSUserDefaults, not as nice as I'd like)
2. this is the right approach if we later want to set more mac-specific prefs, while the ad hoc file would not support multiple prefs, but we'd have to keep code to handle it around even if we switched later, so that's ugly.