Merge lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1010211-run-tests-on-darwin into lp://qastaging/ubuntuone-control-panel

Proposed by Mike McCracken
Status: Merged
Approved by: Diego Sarmentero
Approved revision: 331
Merged at revision: 331
Proposed branch: lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1010211-run-tests-on-darwin
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 67 lines (+32/-7)
1 file modified
run-tests (+32/-7)
To merge this branch: bzr merge lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1010211-run-tests-on-darwin
Reviewer Review Type Date Requested Status
Diego Sarmentero (community) Approve
dobey (community) Approve
Review via email: mp+109250@code.qastaging.launchpad.net

Commit message

- add support for tests on darwin, warn about missing xvfb instead of quiet exit ( LP #1010211 )

Description of the change

- add support for tests on darwin, warn about missing xvfb instead of quiet exit ( LP #1010211 )

Tested on linux, doesn't break anything there.
Also tested on darwin. Works but some tests fail. Not this script's fault!

To post a comment you must log in.
Revision history for this message
dobey (dobey) wrote :

Looks OK to me. Would like to get rid of all the excessive bits in the future (python $u1lint vs just using u1lint, etc type stuff).

review: Approve
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :
Download full text (8.4 KiB)

[ERROR]
Traceback (most recent call last):
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/tests/test_main.py", line 165, in test_all_styles_load
    main.main([sys.argv[0]])
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/__init__.py", line 89, in main
    source.main(app)
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/linux.py", line 22, in main
    from dbus.mainloop.qt import DBusQtMainLoop
exceptions.ImportError: No module named dbus.mainloop.qt

ubuntuone.controlpanel.gui.qt.main.tests.test_main.MainTestCase.test_all_styles_load
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/tests/test_main.py", line 179, in test_installer_option
    main.main([sys.argv[0], "--installer"])
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/__init__.py", line 89, in main
    source.main(app)
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/linux.py", line 22, in main
    from dbus.mainloop.qt import DBusQtMainLoop
exceptions.ImportError: No module named dbus.mainloop.qt

ubuntuone.controlpanel.gui.qt.main.tests.test_main.MainTestCase.test_installer_option
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/tests/test_main.py", line 153, in test_minimized_option
    main.main([sys.argv[0], "--minimized"])
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/__init__.py", line 89, in main
    source.main(app)
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/linux.py", line 22, in main
    from dbus.mainloop.qt import DBusQtMainLoop
exceptions.ImportError: No module named dbus.mainloop.qt

ubuntuone.controlpanel.gui.qt.main.tests.test_main.MainTestCase.test_minimized_option
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/tests/test_main.py", line 185, in test_minimized_with_icon_options
    main.main([sys.argv[0], "--minimized", "--with-icon"])
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/__init__.py", line 89, in main
    source.main(app)
  File "/Users/gatox/canonical/ubuntuone-control-panel-mmcc/ubuntuone/controlpanel/gui/qt/main/linux.py", line 22, in main
    from dbus.mainloop.qt import DBusQtMainLoop
exceptions.ImportError: No module named dbus.mainloop.qt

ubuntuone.controlpanel.gui.qt.main.tests.test_main.MainTestCase.test_minimized_with_icon_options
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/Users/ga...

Read more...

review: Needs Fixing
Revision history for this message
Diego Sarmentero (diegosarmentero) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches