Merge lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1012887-controlpanel-darwin into lp://qastaging/ubuntuone-control-panel

Proposed by Mike McCracken
Status: Merged
Approved by: Roberto Alsina
Approved revision: 335
Merged at revision: 332
Proposed branch: lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1012887-controlpanel-darwin
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 34 lines (+6/-6)
2 files modified
ubuntuone/controlpanel/gui/qt/main/__init__.py (+5/-5)
ubuntuone/controlpanel/gui/qt/main/twisted_main.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1012887-controlpanel-darwin
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
Review via email: mp+110637@code.qastaging.launchpad.net

Commit message

- use twisted reactor main loop on darwin as on windows (lp:1012887)

Description of the change

- use twisted reactor main loop on darwin as on windows (lp:1012887)

also renames modules because darwin and windows both use the former 'windows.py'.

To post a comment you must log in.
334. By Mike McCracken

cleanup branch: remove call to raise_(), saved for another branch

335. By Mike McCracken

finish cleanup of raise_ changes

Revision history for this message
Alejandro J. Cura (alecu) wrote :

+1, tests pass on linux

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches