Merge lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1018614-darwin-raise into lp://qastaging/ubuntuone-control-panel
Proposed by
Mike McCracken
| Status: | Merged |
|---|---|
| Approved by: | Mike McCracken |
| Approved revision: | 338 |
| Merged at revision: | 337 |
| Proposed branch: | lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1018614-darwin-raise |
| Merge into: | lp://qastaging/ubuntuone-control-panel |
| Diff against target: |
34 lines (+5/-3) 2 files modified
ubuntuone/controlpanel/gui/qt/gui.py (+4/-3) ubuntuone/controlpanel/gui/qt/tests/test_start.py (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~mikemc/ubuntuone-control-panel/fix-1018614-darwin-raise |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Manuel de la Peña (community) | Approve | ||
| Brian Curtin (community) | Approve | ||
| Roberto Alsina (community) | Approve | ||
|
Review via email:
|
|||
Commit message
- Call raise_() after show() to ensure the window is brought to the front on darwin. (LP: #1018614)
Description of the change
- Call raise_() after show() to ensure the window is brought to the front on darwin. (LP: #1018614)
To post a comment you must log in.
Revision history for this message
| Roberto Alsina (ralsina) wrote | # |
Revision history for this message
| Mike McCracken (mikemc) wrote | # |
Revision history for this message
| Roberto Alsina (ralsina) | # |
review:
Approve
Revision history for this message
| Manuel de la Peña (mandel) | # |
review:
Approve
Revision history for this message
| Ubuntu One Auto Pilot (otto-pilot) wrote | # |
Download full text (154.5 KiB)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Can we add a test in which we assert that raise is not called in anything but darwin. You can patch the sys.platform used in gui.py to return darwin or order according to the test.