Merge lp://qastaging/~mikemc/ubuntuone-control-panel/set-default-folders into lp://qastaging/ubuntuone-control-panel

Proposed by Mike McCracken
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 372
Merged at revision: 370
Proposed branch: lp://qastaging/~mikemc/ubuntuone-control-panel/set-default-folders
Merge into: lp://qastaging/ubuntuone-control-panel
Diff against target: 59 lines (+32/-2)
2 files modified
ubuntuone/controlpanel/utils/darwin.py (+8/-2)
ubuntuone/controlpanel/utils/tests/test_darwin.py (+24/-0)
To merge this branch: bzr merge lp://qastaging/~mikemc/ubuntuone-control-panel/set-default-folders
Reviewer Review Type Date Requested Status
Alejandro J. Cura (community) Approve
Roberto Alsina (community) Approve
Review via email: mp+130171@code.qastaging.launchpad.net

Commit message

- Set default folders to sync for first-run wizard on darwin (LP: #1067648)

Description of the change

- Set default folders to sync for first-run wizard on darwin (LP: #1067648)

To post a comment you must log in.
372. By Mike McCracken

Use platform.expand_user to ensure that default folders are bytes. Add test for this.

Revision history for this message
Roberto Alsina (ralsina) :
review: Approve
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches