Oops, you meant to return MirWaitHandle; also, you're missing a callback on completion? Oh, no, you just haven't updated the prototype :).
1109- optional SurfaceId id = 1;
1110+ optional BufferStreamId id = 1;
I *think* this breaks protocol, but that should still be ok. You might need to be careful in CI, though?
I'm somewhat disappointed that we can't pull a vsyncish signal out of this and not need the client-side animation throttling, but that's probably for a later MP.
144+MirBufferSt ream* mir_connection_ create_ buffer_ stream( MirConnection *connection,
Oops, you meant to return MirWaitHandle; also, you're missing a callback on completion? Oh, no, you just haven't updated the prototype :).
1109- optional SurfaceId id = 1;
1110+ optional BufferStreamId id = 1;
I *think* this breaks protocol, but that should still be ok. You might need to be careful in CI, though?
I'm somewhat disappointed that we can't pull a vsyncish signal out of this and not need the client-side animation throttling, but that's probably for a later MP.
Otherwise looks sensible to me.