Mir

Code review comment for lp://qastaging/~mir-team/mir/animated-cursors

Revision history for this message
Robert Carr (robertcarr) wrote :

>> needs info:
>> 130 + * Create a new buffer stream unattached to a surface.
>>
>. I guess, outside of cursors, is this a universal concept? I guess I'm just a bit leery of saying
>> "this is a surface, with a bufferstream" and "this is a bufferstream", because it seems difficult to >> understand, if you're only looking at the API.

I think it is a universal concept...BufferStreams also being useful at least for:

1. Decorations Next
2. Subwindowing/nested compositors

Maybe the new text of the comment is a little better?

/**
 * Create a new buffer stream. BufferStreams provide a way
 * to exchange buffers with the server without directly
 * posting them to a surface.
 * For example, the resulting buffer stream may be used
 * with mir_cursor_configuration_from_buffer_stream in order to post images to the system
 * cursor.
 *

>> needs fixings:
>> 216 + * If the configuration successfully applied buffers from the stream will be used
>> needs a verb
>> 220 + * \param [in] hotspot_y The y-coordinate displacement within the image to place on the
>> cursor. typo

Fixed! Thanks.

« Back to merge proposal