Code review comment for lp://qastaging/~mitya57/indicator-datetime/lp1502480

Revision history for this message
Alkis Georgopoulos (alkisg) wrote :

It looks fine to me.

In shell, to avoid the loop, I do:
if echo ":$XDG_CURRENT_DESKTOP:" | grep -q ":Unity:"; then
    echo yes
else
    echo no
fi

Performance-wise it's fine, it needs only one malloc (for strcat) instead of many (for split), but I'm not sure how readable it is.

review: Approve

« Back to merge proposal