Merge lp://qastaging/~mohyt/drizzle/json_server_schema into lp://qastaging/drizzle
Proposed by
Mohit Srivastava
Status: | Merged |
---|---|
Merged at revision: | 2642 |
Proposed branch: | lp://qastaging/~mohyt/drizzle/json_server_schema |
Merge into: | lp://qastaging/drizzle |
Diff against target: |
1049 lines (+935/-2) 10 files modified
plugin/json_server/ddl/schema.cc (+158/-0) plugin/json_server/ddl/schema.h (+110/-0) plugin/json_server/error.cc (+58/-0) plugin/json_server/error.h (+158/-0) plugin/json_server/json_handler.cc (+101/-0) plugin/json_server/json_handler.h (+125/-0) plugin/json_server/json_server.cc (+107/-2) plugin/json_server/plugin.ini (+6/-0) plugin/json_server/tests/r/basic.result (+18/-0) plugin/json_server/tests/t/basic.test (+94/-0) |
To merge this branch: | bzr merge lp://qastaging/~mohyt/drizzle/json_server_schema |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stewart Smith (community) | Approve | ||
Review via email: mp+177285@code.qastaging.launchpad.net |
Description of the change
Added create & drop Schema functionality on json server
To post a comment you must log in.
Minor fixes: json_server/ ddl/schema. cc that it's mostly just a copy from drizzled/ statement/ create_ schema. cc and friends.
- Copyright date should be 2011-2013 rather than just 2011
- It would be good to have a comment in plugin/
- Where you use a static buffer for processing input (buffer[1024]) please also provide i a test that tests the limits of this buffer to ensure that there are not exploitable buffer overflows.
Questions:
- Why is num_threads set to 1? I don't think this should be here.
Otherwise looks good.