Code review comment for lp://qastaging/~mterry/aptdaemon/progress-tweaks

Am Montag, den 11.06.2012, 14:57 +0000 schrieb Matthew Paul Thomas:
> Review: Needs Fixing design
>
> In the long term, I think Update Manager should use its own progress UI rather than Aptdaemon's progress window. In <https://wiki.ubuntu.com/SoftwareUpdates#Installing> I show the initial prompt morphing into the progress window, when later morphs into the report of success or failure; that's probably difficult as long as they're separate executables. More importantly, Aptdaemon's progress window probably should be modal to its parent window, so that -- for example -- a media player isn't confused by you doing something else in its window while it is blocked waiting for a codec to install. The Software Updater progress window, meanwhile, shouldn't be modal to anything.

A small technical correction: The aptdaemon dialog is part of the
update-manager process. The dialog is created by update-manager.

But sessioninstaller (the codec installer) is a different story. The
codec requesting application calls a D-Bus (PackageKit) method and so
starts the codec installer on demand. The D-Bus call also includes a
window id to which sessioninstaller should be transient for. So if this
isn't the case you should fill a bug.

> Grammar nit: "Setup" is a noun. The verb is "Set up". (I mention this because it's a common UI mistake too.)

This is also a common mistake of me. :)

> + self.label_role.set_markup("<big><b>%s</b></big>" % self.custom_label)
>
> + self.label_role.set_markup("<big><b>%s</b></big>" % role)
>
> This is a progress window, not an alert, so the text shouldn't be any larger or bolder than normal.

Good point, but it seems to introduce a strange weighting. It makes the
difference to the status label harder to spot. I attached some
screenshots to this mail.