Merge lp://qastaging/~mterry/phablet-tools/unlock into lp://qastaging/phablet-tools

PASSED: Continuous integration, rev:269
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/311/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-amd64-ci/83
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-armhf-ci/83
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-i386-ci/83

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/311/rebuild

PASSED: Continuous integration, rev:270
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/312/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-amd64-ci/84
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-armhf-ci/84
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-i386-ci/84

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/312/rebuild

+ exec_with_adb sh -c "if ! dpkg -s unity8-autopilot >/dev/null 2>/dev/null; then echo 'Installing unity8-autopilot on device for unlock support'; DEBIAN_FRONTEND=noninteractive apt-get -y -q install unity8-autopilot; fi"

Ideally devices should be in read only state for app testing. What I do to get the autopilot modules in phablet-test-click-setup is to grab the installed unity8 versions of the package and grab it's source package (pull-lp-source). We should do something similar here.

Seeding unity8-autopilot is fine as well. We are in definite need of a proper QA story here.

The rest looks fine btw! :-)

Sergio, I think seeding is best bet, since the unlock script uses some python methods installed by the package.

Which branch has the seed config that I need to change?

On Tue, Apr 29, 2014 at 4:39 PM, Michael Terry
<email address hidden>wrote:

> Sergio, I think seeding is best bet, since the unlock script uses some
> python methods installed by the package.
>
> Which branch has the seed config that I need to change?
>

For seeding, that's just the regular seed branch:
lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.utopic

What do you think of splitting the autopilot package into some smaller
bits?

I'm looping in rsalveti and ogra

Oh. I thought you meant some special seeding that the QA images use. No, I'm not a fan of seeding it on all the images...

We could change the unlock script to be more contained -- we could probably duplicate some of the necessary python code.

But doesn't the autopilot scripts do some magic around installing files to /home/phablet/autopilot?

PASSED: Continuous integration, rev:272
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/313/
Executed test runs:
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-trusty-amd64-ci/85
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-trusty-armhf-ci/85
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-trusty-i386-ci/85

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/313/rebuild

OK... I've updated the branch to download a copy of unity8 and use its files (storing the python module in /home/phablet/autopilot). But A) this needs a change on the unity8 side to be able to specify a PYTHONPATH for the unlock-device script. And B) we need to grab the dependencies for unity8-autopilot (like ubuntu-ui-toolkit-autopilot).

I don't want to reinvent the wheel here. Is there already a function somewhere else that nicely puts modules and their dependencies in /home/phablet/autopilot?

As an aside, this is becoming complicated. How does unlocking work today on a readonly device? You'd need the unity8 python module there too. So this must be a solved problem. (And if it isn't, can we not block this change on that feature?)

On Wed, Apr 30, 2014 at 5:19 PM, Michael Terry
<email address hidden>wrote:

> OK... I've updated the branch to download a copy of unity8 and use its
> files (storing the python module in /home/phablet/autopilot). But A) this
> needs a change on the unity8 side to be able to specify a PYTHONPATH for
> the unlock-device script. And B) we need to grab the dependencies for
> unity8-autopilot (like ubuntu-ui-toolkit-autopilot).
>
> I don't want to reinvent the wheel here. Is there already a function
> somewhere else that nicely puts modules and their dependencies in
> /home/phablet/autopilot?
>

phablet-click-test-setup does this; that's one of the reasons you can test
click packages on read only images.

>
> As an aside, this is becoming complicated. How does unlocking work today
> on a readonly device? You'd need the unity8 python module there too. So
> this must be a solved problem. (And if it isn't, can we not block this
> change on that feature?)
>

Read only devices don't have unlocking; if you add the TODO, it's fine; I
think it's kind of a failure that we can't have a testing story for a
consumer device though.

OK, I've reverted this branch to the assume-readwrite-image version. I'd really prefer not to bundle all these features together. This change is blocking landing the split greeter, so I'd like to make this as targeted as possible (this set of merges is already taking on another of your wish list items to move the logic out of ubuntu-test-cases into phablet-tools).

I've added a TODO about readonly support. Ready for review.

PASSED: Continuous integration, rev:274
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/314/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-amd64-ci/86
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-armhf-ci/86
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-i386-ci/86

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/314/rebuild

PASSED: Continuous integration, rev:275
http://jenkins.qa.ubuntu.com/job/phablet-tools-ci/315/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-amd64-ci/87
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-armhf-ci/87
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-tools-trusty-i386-ci/87

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/phablet-tools-ci/315/rebuild