Code review comment for lp://qastaging/~mterry/phablet-tools/unlock

Revision history for this message
Michael Terry (mterry) wrote :

OK... I've updated the branch to download a copy of unity8 and use its files (storing the python module in /home/phablet/autopilot). But A) this needs a change on the unity8 side to be able to specify a PYTHONPATH for the unlock-device script. And B) we need to grab the dependencies for unity8-autopilot (like ubuntu-ui-toolkit-autopilot).

I don't want to reinvent the wheel here. Is there already a function somewhere else that nicely puts modules and their dependencies in /home/phablet/autopilot?

As an aside, this is becoming complicated. How does unlocking work today on a readonly device? You'd need the unity8 python module there too. So this must be a solved problem. (And if it isn't, can we not block this change on that feature?)

« Back to merge proposal