Code review comment for lp://qastaging/~mterry/snap-confine/fix-tests

Revision history for this message
Michael Terry (mterry) wrote :

That doesn't help with the security side of things (since a malicious user can also skip that block with UBUNTU_CORE_LAUNCHER_NO_ROOT=1).

And checking the binary path isn't otherwise a root-user-thing, right?. So I'm leery of throwing it in that block just to avoid a check for SNAPPY_LAUNCHER_INSIDE_TESTS.

« Back to merge proposal