Code review comment for lp://qastaging/~mterry/unity-scope-click/snap-root

Revision history for this message
dobey (dobey) wrote :

On Mon, 2016-11-07 at 20:19 +0000, Michael Terry wrote:
> I'm running the in-progress unity8 desktop snap (with fixes in silo
> 2129), and I'm seeing the tall orange store button (which goes to the
> snap store, not the click store).  But it's missing the logo -- which
> this MP fixes.
>
> Are we using some of this scope's code to jump into the snap
> store?  In which case we do need this still.  (I couldn't find code
> in the snappy scope to present the orange store button, but I didn't
> look hard.)

Marcus assured me that the scopes API or shell side should be handling
this and prepending the $SNAP value to any paths for artwork and such
that get passed through, and not something we should deal with in the
scope itself.

So it seems like the fix for that is still missing from the other silo
with the api/shell fixes.

« Back to merge proposal