Code review comment for lp://qastaging/~muktupavels/compiz/gtk-window-decorator-4

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> Something is wrong with d->surface. Added cairo_surface_write_to_png
> (d->surface, "test.png"); in decor_update_meta_window_property.
>
> With hack decorations are visible in test.png, but without hack it is
> empty/transparent.

Yeah, that's strange. I've also tried to do something with this, but I wasn't able to find where the problem happens.
It's like that a fully transparent surface create troubles. While not calling the XChangeProperty function seems the decorator not to redraw the surface properly.

Not sure if there's instead a problem caused by the surface not being reinitialized correctly... By the way, thanks for your further researches and it would be nice if you could continue. Although, I'm more concerned with crashes you found (and I didn't) due to BadWindow arguments.

« Back to merge proposal