Code review comment for lp://qastaging/~muktupavels/compiz/gtk-window-decorator-4

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

> How about adding 'gdk_x11_display_error_trap_push (gdkdisplay);' in gtk-
> window-decorator.c? After short period of testing it seem that I am not
> getting crashes. I think it should be added in part 3 if you agree.

Ok, but and pop it also. At this point you should not get errors.
And you can also remove the other instances.

> Is it possible to run decorator in unity? If I try to enable it it will
> disable unity.

No currently it's not possible.

> So now I have only problem with black decorations, but that might be nvidia
> problem. Video with it:
> https://www.dropbox.com/s/2ba27yvyfb8gjsi/VIDEO0009.mp4?dl=0

Mh, no I've not found that issue definitely.

« Back to merge proposal