Code review comment for lp://qastaging/~muktupavels/compiz/gtk-window-decorator-4

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

> Was he launching gdk-window-decorator using GDK_SYNCHRONIZE or calling
> XSynchronize (x, True) somewhere?

GDK_SYNCHRONIZE

> Anyway, all these problems seems to be Bad{Window,Pixmap} issues, that - even
> if it would be better to avoid - it's not a big problem to ignore them using
> gdk traps (at the end these can be considered only warnings).

I added one more error trap. See gtk-window-decorator-3 part.

> I'm more concerned about the black textures issue you get, and it would be
> nice to find why that happens if we clear them.
> If I'm not wrong these aren't destroyed at decor plugin level, right?

I am not good at reading stack traces and/or debuging, but it looks like crash is happending in cairo. Crash is happening when calling cairo_destroy (d->cr) in decorator.c (692 line). If I delete it then it is not crashing, also black decoration problem dissapears. Any ideas? This looks like last problem.

« Back to merge proposal