Merge lp://qastaging/~mvo/snap-confine/auto-bind-mount-nvidia into lp://qastaging/~snappy-dev/snap-confine/trunk

Proposed by Michael Vogt
Status: Needs review
Proposed branch: lp://qastaging/~mvo/snap-confine/auto-bind-mount-nvidia
Merge into: lp://qastaging/~snappy-dev/snap-confine/trunk
Diff against target: 67 lines (+34/-1)
2 files modified
debian/usr.bin.ubuntu-core-launcher (+5/-0)
src/main.c (+29/-1)
To merge this branch: bzr merge lp://qastaging/~mvo/snap-confine/auto-bind-mount-nvidia
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Disapprove
Review via email: mp+291983@code.qastaging.launchpad.net

Description of the change

This branch adds more magic to the ubuntu-core-launcher, this time to make automatic mounting of the nvidia libgl dir work.

However we do not have to do it this way, we could modify all of the nvidia-* drivers to ship a systemd mount unit file that does this mounting. In terms of getting stuff into the release this looks more risky though.

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I didn't do a code review, but I think I prefer the systemd mount approach for a few reasons:

1. added more code to a setuid launcher is not ideal. This thing is already quite large
2. the launcher would need to be updated for other non-nvidia drivers
3. the launcher needs to be updated if the nvidia packaging changes. This issue is aggravated when considering LTS backports where the launcher may need to be part of the backports stack if something changes in later releases

The nice thing about the systemd approach is this systemd unit can be shipped by the packages that are in control of where the files are (ie, the nvidia drivers packages). In this way, all the paths are maintained within one package.

review: Disapprove

Unmerged revisions

129. By Michael Vogt

add auto bind mount of the nvidia libgl dir

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches