Code review comment for lp://qastaging/~mvo/snap-confine/auto-bind-mount-nvidia

Revision history for this message
Jamie Strandboge (jdstrand) wrote :

I didn't do a code review, but I think I prefer the systemd mount approach for a few reasons:

1. added more code to a setuid launcher is not ideal. This thing is already quite large
2. the launcher would need to be updated for other non-nvidia drivers
3. the launcher needs to be updated if the nvidia packaging changes. This issue is aggravated when considering LTS backports where the launcher may need to be part of the backports stack if something changes in later releases

The nice thing about the systemd approach is this systemd unit can be shipped by the packages that are in control of where the files are (ie, the nvidia drivers packages). In this way, all the paths are maintained within one package.

review: Disapprove

« Back to merge proposal